Re: [PATCH 0/3] Staging: vt6655: remove PBYTE/PWORD/PDWORD typedef

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jun 18, 2010 at 10:21:03AM -0700, Greg KH wrote:
> On Sat, Jun 05, 2010 at 03:13:46PM -0700, Charles Clément wrote:
> > Remove the following typedef from ttype.h and replace with the actual type:
> > 	PBYTE	->	unsigned char *
> > 	PWORD	->	unsigned short *
> > 	PDWORD	->	unsigned long *
> 
> After applying all of your typedef cleanup patches, I'm getting a bunch
> of compiler warnings on x86-64 like:
> 	drivers/staging/vt6655/iwctl.c: In function ‘iwctl_get_wireless_stats’:
> 	drivers/staging/vt6655/iwctl.c:119:36: warning: cast from pointer to integer of different size
> 
> I'll go see what went wrong...

Ah, found it:
	Staging: vt6655: remove U32 custom macro
was wrong.

The line:
	-typedef unsigned long           U32;    /* 32-bit unsigned integer */

was fine, but you then went and made "U32" a "u32" all through the
driver, which you would think would be correct based on the code.  But
it's not, you need to make it a real "unsigned long" instead.

I'll go see if I can revert this one by hand or just fix it up...

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux