Dan Carpenter wrote: > copy_to_user() returns the number of bites remaining but we want to > return a negative error code here. > > Signed-off-by: Dan Carpenter <error27@xxxxxxxxx> > > diff --git a/drivers/staging/batman-adv/device.c > b/drivers/staging/batman-adv/device.c index ad82ec4..c7f3978 100644 > --- a/drivers/staging/batman-adv/device.c > +++ b/drivers/staging/batman-adv/device.c > @@ -196,7 +196,7 @@ ssize_t bat_device_read(struct file *file, char __user > *buf, size_t count, kfree(device_packet); > > if (error) > - return error; > + return -EFAULT; > > return sizeof(struct icmp_packet); > } Thanks for your patch, but this collides with a patch currently waiting in GregKH's queue. I will port that patch on top of that. Best regards, Sven
Attachment:
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
