Hello Kenneth,
I think the subject of your mail could be a little more informative,
e.g.: [PATCH] Staging: comedi: s526: Fix checkpatch.pl issues
You also have to provide a sign off line with your name and email address
in the body of the message:
Signed-off-by: Name < email >
On Sat, May 29, 2010 at 02:26:44PM -0700, Kenneth Hale wrote:
> diff --git a/drivers/staging/comedi/drivers/s526.c b/drivers/staging/comedi/drivers/s526.c
> index 07c21e6..30fb65e 100644
> --- a/drivers/staging/comedi/drivers/s526.c
> +++ b/drivers/staging/comedi/drivers/s526.c
> @@ -114,7 +114,7 @@ static const int s526_ports[] = {
> };
>
> struct counter_mode_register_t {
> -#if defined (__LITTLE_ENDIAN_BITFIELD)
> +#if defineD(__LITTLE_ENDIAN_BITFIELD)
This is a typo I guess.
Finally, there are multiple kernel log levels, you only used the KERN_ERR
one, although it might be the right one for some places, like here:
> @@ -796,7 +793,7 @@ static int s526_gpct_winsn(struct comedi_device *dev,
> break;
> default: /* Impossible */
> printk
> - ("s526: INSN_WRITE: Functionality %d not implemented yet\n",
> + (KERN_ERR "s526: INSN_WRITE: Functionality %d not implemented yet\n",
> devpriv->s526_gpct_config[subdev_channel].app);
> return -EINVAL;
> break;
some other messages may be only informational and could be logged with KERN_INFO.
--
Charles Clément
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
