On Thu, 2010-05-20 at 08:36 -0700, Greg KH wrote: > On Thu, May 20, 2010 at 01:53:34AM -0700, Joe Perches wrote: > > On Thu, 2010-05-20 at 10:39 +0200, Tobias Klauser wrote: > > > +++ b/drivers/staging/hv/vmbus_drv.c > > > -const static struct pci_device_id microsoft_hv_pci_table[] = { > > > +static const struct pci_device_id microsoft_hv_pci_table[] = { > > > { PCI_DEVICE(0x1414, 0x5353) }, /* VGA compatible controller > > > */ > > > { 0 } > > > }; > > > > DEFINE_PCI_DEVICE_TABLE ? > > No, I hate that macro. You mean the one that every other instance of a definition of struct pci_device_id uses? The one that puts the data in .devinit.rodata? Didn't you signed off on 90a1ba0c5e39eeea278f263c28ae02166c5911c8 ? What happened to change your mind? _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel