Ok,
On Wed, May 19, 2010 at 11:48:51AM -0700, Joe Perches wrote:
> An ethernet broadcast address is also an ethernet multicast
> address, so some of these are redundant, but that's probably
> for another patch.
>
> > - if (!is_multicast_ether_addr(pbyFrame) && !IS_BROADCAST_ADDRESS(pbyFrame)) {
> > + if (!is_multicast_ether_addr(pbyFrame) && !is_broadcast_ether_addr(pbyFrame)) {
> []
> > if (is_multicast_ether_addr(&(psEthHeader->abyDstAddr[0])) ||
> > - IS_BROADCAST_ADDRESS(&(psEthHeader->abyDstAddr[0]))) {
> > + is_broadcast_ether_addr(&(psEthHeader->abyDstAddr[0]))) {
> []
> > if (is_multicast_ether_addr(&(psEthHeader->abyDstAddr[0])) ||
> > - IS_BROADCAST_ADDRESS(&(psEthHeader->abyDstAddr[0]))) {
> > + is_broadcast_ether_addr(&(psEthHeader->abyDstAddr[0]))) {
>
I'll make a patch where I remove the is_multicast_ether_addr where
appropriate.
> Also, "&(foo->bar[0])" can generally be replace by "foo->bar"
> for easier reading.
>
Maybe later for this one...
Thanks,
--
Charles Clément
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
