On Wed, 2010-05-19 at 10:33 -0700, Greg KH wrote: > On Wed, May 19, 2010 at 10:16:24AM -0700, Joe Perches wrote: > > It's all a piece. Fixes are fixes. > > Unnecessary code is unnecessary. > I agree, but this addition, to fix a bug, is not a big deal. It contains an unnecessary set as well as unappealing line wrapping so reading it is confusing. ymmv, etc. > > Of course a macro shouldn't have a return, > > though a function would. > Then why did you just suggest writing a macro with a return statement? Defective typing. Wrote macro/function, prototyped macro, wrote function. More coffee necessary. cheers, Joe _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
