On Thu, 2010-05-13 at 18:28 +0800, Mark wrote:
> I'd like to get some feedback on this patch, since I'm not sure this is the best
> way to fix the long line lengths.
> ---
> drivers/staging/comedi/comedi.h | 15 ++++++++++-----
> 1 files changed, 10 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/comedi/comedi.h b/drivers/staging/comedi/comedi.h
> index 3e3663f..ea96a83 100644
> --- a/drivers/staging/comedi/comedi.h
> +++ b/drivers/staging/comedi/comedi.h
> @@ -267,7 +267,8 @@
> * streaming input/output */
> INSN_CONFIG_GET_HARDWARE_BUFFER_SIZE = 2006,
> INSN_CONFIG_SET_COUNTER_MODE = 4097,
> - INSN_CONFIG_8254_SET_MODE = INSN_CONFIG_SET_COUNTER_MODE, /* deprecated */
> + /* deprecated */
/* INSN_CONFIG_8254_SET_MODE is deprecated */
[]
> - static inline unsigned NI_CDIO_SCAN_BEGIN_SRC_RTSI(unsigned rtsi_channel)
> + static inline unsigned
> + NI_CDIO_SCAN_BEGIN_SRC_RTSI(unsigned rtsi_channel)
> {
> return NI_USUAL_RTSI_SELECT(rtsi_channel);
> }
It'd be better to start the functions in column 1
static inline unsigned int NI_CDIO_SCAN_BEGIN_RTSI(unsigned int rtsi_channel)
{
return NI_USUAL_RTSI_SELECT(rtsi_channel);
}
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
