Re: [PATCH] Staging: wlags49_h2: fixed C99 comments style issues in wl_profile.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

>> -//     } else {
>> -//             this should not be debug time info, it is an enduser data entry error ;?
>> -//             DBG_WARNING(DbgInfo, "%s invalid; will be ignored\n", PARM_NAME_MICROWAVE_ROBUSTNESS);
>> +/*     } else {
>> +               this should not be debug time info, it is an enduser data entry error ;?
>> +               DBG_WARNING(DbgInfo, "%s invalid; will be ignored\n", PARM_NAME_MICROWAVE_ROBUSTNESS); */
> In such case you have lost the internal comments. I think it should look like
> /*
> } else {
> /* ... */

Sent a new patch. I tried the nested comments but gcc wont handle it
correctly (maybe I am wrong here). Please discard the old patch and
use this new one.

-//     } else {
-//             this should not be debug time info, it is an enduser
data entry error ;?
-//             DBG_WARNING(DbgInfo, "%s invalid; will be ignored\n",
PARM_NAME_MICROWAVE_ROBUSTNESS);
+       /* } else { */
+               /* this should not be debug time info, it is an
enduser data entry error ;? */
+               /* DBG_WARNING(DbgInfo, "%s invalid; will be
ignored\n", PARM_NAME_MICROWAVE_ROBUSTNESS); */
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux