Hi, On 05/08/2010 11:59 AM, Pekka Enberg wrote: > > Andrew Morton wrote: >> The driver appears to be controlled by some nasty-looking ioctl against >> some fd. None of it is documented anywhere. It should be. You're >> proposing here a permanent extension to the kernel ABI which we will >> need to maintain for ever. That's a big deal and it is the very first >> thing reviewers will look at, before even considering the code. > > I thought we got rid of it? Nitin? > No, we didn't get rid of any ioctls. In fact, issuing ioctls is how we configure various ramzswap devices (using rzscontrol utility). The functionality of all these ioctls is well documented in rzscontrol manpage. Now, I will also add relevant comments in the code. >> RZSIO_GET_STATS looks to be hopeless from a long-term maintainability >> POV. It's debug code and it would be better to move it into a debugfs >> file, where we can then add and remove things at will. > > Yup. > Its not debug code. This ioctl is how we send stats about given ramzswap device to userspace: rzscontrol /dev/ramzswap --stats, invokes this ioctl and prints the stats. I will add comments to this part to make it clear. Thanks, Nitin _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
