Re: [PATCH] Staging: vt6656: remove unnecessary #ifdef

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 07, 2010 at 06:13:50PM -0500, H Hartley Sweeten wrote:
> On Friday, May 07, 2010 3:47 PM, Charles Clément wrote:
> > Subject: [PATCH] Staging: vt6656: remove unnecessary #ifdef
> >
> >
> > Signed-off-by: Charles Clément <caratorn@xxxxxxxxx>
> > ---
> >  drivers/staging/vt6656/ttype.h |    5 -----
> >  1 files changed, 0 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/staging/vt6656/ttype.h b/drivers/staging/vt6656/ttype.h
> > index 692b63e..5768862 100644
> > --- a/drivers/staging/vt6656/ttype.h
> > +++ b/drivers/staging/vt6656/ttype.h
> > @@ -133,11 +133,6 @@ typedef DWORD *          PDWORD;
> >  
> >  typedef QWORD *          PQWORD;
> >  
> > -// handle declaration
> > -#ifdef STRICT
> >  typedef void *HANDLE;
> > -#else
> > -typedef void *HANDLE;
> > -#endif
> 
> I cleaner option would have been to remove the typedef completely and replace
> all uses of HANDLE with void *.

Yes, I think too but that will be for another patch.

> 
> Just my 0.02....
> 
> Regards,
> Hartley

-- 
Charles Clément

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux