On Wed, 5 May 2010, Nitin Gupta wrote: > > ramzswap driver creates RAM based block devices which can be > used (only) as swap disks. Pages swapped to these disks are > compressed and stored in memory itself. Ok, this patch series looks way better, if only because it looks less hacky. That said, I absolutely _hate_ the f*cking notifier model that takes "type" flags. It's a disgrace. It's a horrible horrible model. I'd much rather bind a nice "swap_operations" structure to the device, and have that structure have function pointers for the different operations. No stupid "operation type codes". Real, honest-to-goodness function pointers. The notifier layer is a total piece of sh*t. I'm sorry I ever merged it, and I'm _doubly_ sorry that it's use is so horribly widespread. It's a mistake. Linus _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
