On Mon, 2010-05-03 at 19:30 +0100, Adam Latham wrote: > Subject: [PATCH] Staging: wlan-ng: fix various whitespace and 80 char issues in hfa384x_usb.c > This is a patch to fix various whitespace and 80 character style issues found by checkpatch.pl tool > Signed-off-by: Adam Latham <adam.latham@xxxxxxxxxxxxxxxxxxx> Hi Adam. > diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c > index 5df56f0..b7a319f 100644 > --- a/drivers/staging/wlan-ng/hfa384x_usb.c > +++ b/drivers/staging/wlan-ng/hfa384x_usb.c [] > @@ -451,7 +451,7 @@ static void hfa384x_usb_defer(struct work_struct *data) > if (test_bit(WORK_RX_HALT, &hw->usb_flags)) { > int ret; > > - usb_kill_urb(&hw->rx_urb); /* Cannot be holding spinlock! */ > + usb_kill_urb(&hw->rx_urb); /* Cannot be holding spinlock!*/ It's most common to use a space before the trailing */ > @@ -2619,7 +2619,7 @@ int hfa384x_drvr_start(hfa384x_t *hw) > pr_debug("First cmd_initialize() failed (result %d),\n", > result1); > pr_debug > - ("but second attempt succeeded. All should be ok\n"); > + ("but second attempt succeeded.All should be ok\n"); Removing the space after a period here is not an improvement. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel