Re: [PATCH]: pohmelfs/config.c: 2 * redundant code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 19, 2010 at 09:43:26AM +0000, d binderman wrote:
> 
> 
> Hello there,
> 
> I just ran the sourceforge tool cppcheck over the source code of the
> new Linux kernel 2.6.34-rc1
> 
> It said
> 
> [staging/pohmelfs/config.c:610]: (style) Redundant condition. It is safe to deallocate a NULL pointer
> [staging/pohmelfs/config.c:613]: (style) Redundant condition. It is safe to deallocate a NULL pointer
> 
> The source code is
> 
>                 if (g->hash_string)
>                         kfree(g->hash_string);
> 
>                 if (g->cipher_string)
>                         kfree(g->cipher_string);
> 
> 
> Proposed patch file attached.

Please do not attach patches in base64 format (actually, don't attach
patches at all, put them inline.)

care to resend it?

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux