2010/4/28 Greg KH <gregkh@xxxxxxx>: > On Wed, Apr 28, 2010 at 08:45:35PM +0200, matthias wrote: >> This drivers allows a communication with the Analog Devices ADIS16255 >> Low Power Gyroscope over SPI. > > Why is this going to be a staging driver? Is there a problem with it > going into the main portion of the kernel now? - No one else has tested it, so I think if it stays in staging, others have the possibility to test it. - It has checkpatch issues - Odd stuff like the AD_CHK(_ss) macro - I'm not sure to which subsystem it should be added (maybe industrial io, but this is still staging. Any suggestions?) - Improvements of code on protocol hierarchy needed (e.g. shutdown device commands in remove function; it is not obvious which sample rate the device uses) Regards, Matthias > > thanks, > > greg k-h > -- motzblog.wordpress.com _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
