On Fri, Mar 19, 2010 at 12:00:59AM +0100, Lars Lindley wrote: > On 2010-03-18 17:22, Pekka Enberg wrote: > > Lars Lindley wrote: > >> +/* refer Bitmap2RateValue table */ > >> +#define LOCAL_ALL_SUPPORTED_RATES_BITMAP 0x130c1a66 /* > >> + * the bitmap value > >> + * of all the H/W > >> + * supported rates: > >> + * 1, 2, 5.5, 11, > >> + * 6, 9, 12, 18, > >> + * 24, 36, 48, 54 > >> + */ > > > > The comments look funny. You might want to move them above the #defines. > > > >> + u8 region; /* real region setting of the device */ > >> + u8 Reserved_1[2]; > >> + > >> +/* power-save variables */ > > > > I think this wants to be moved one indentation level to the right. > > > Ok here's a patch that applies over the old one to fix this.. > Hope it looks all right.. :) Can you merge the two of them together and resend? thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
