On Tue, Apr 27, 2010 at 10:30:03PM -0700, Joe Perches wrote: > On Tue, 2010-04-27 at 16:02 -0700, Greg KH wrote: > > On Mon, Mar 29, 2010 at 12:34:28AM -0700, Joe Perches wrote: > > > Make variables static where appropriate > > > Rename dt3155_<foo_with_long_names> variables to dt_<foo_tla> > > > to reduce code length and make more lines fit well in 80 chars > > > Remove now unnecessary .h files > > > Change indent to use tabs > > > Remove unused functions > > > Used bool more often > > > Checkpatch clean > > > > This is too much in one patch, sorry. > > You should be more consistent. I am human. > http://www.tuxradar.com/content/newbies-guide-hacking-linux-kernel > Greg even said, "submit one big patch if you want" Yes, but I will then help to guide them to make it a more reasonable, and reviewable, patch :) > > It also doesn't apply due to > > other changes in these files (that you then remove in patch 3) from > > other developers. > > No, it doesn't apply because you chose to apply other patches > before this one. Those patches were sent to me before yours, sorry. thanks, greg "slowly catching up" k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
