On Wed, Apr 21, 2010 at 07:29:10PM +0200, Alessandro Ghedini wrote:
> This patch fixes most of the style warnings found with checkpatch.pl in the
> hfa384x_usb.c file.
>
> Signed-off-by: Alessandro Ghedini <al3xbio@xxxxxxxxx>
> ---
> drivers/staging/wlan-ng/hfa384x_usb.c | 59 ++++++++++++++++++--------------
> 1 files changed, 33 insertions(+), 26 deletions(-)
>
> diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c
> index 5df56f0..db819be 100644
> --- a/drivers/staging/wlan-ng/hfa384x_usb.c
> +++ b/drivers/staging/wlan-ng/hfa384x_usb.c
> @@ -62,7 +62,7 @@
> *
> * hfa384x_drvr_xxxconfig An example of the drvr level abstraction. These
> * functions are wrappers for the RID get/set
> -* sequence. They call copy_[to|from]_bap() and
> +* sequence. They call copy_[to|from]_bap() and
> * cmd_access(). These functions operate on the
> * RIDs and buffers without validation. The caller
> * is responsible for that.
> @@ -351,7 +351,9 @@ static int submit_rx_urb(hfa384x_t *hw, gfp_t memflags)
> hw->rx_urb_skb = skb;
>
> result = -ENOLINK;
> - if (!hw->wlandev->hwremoved && !test_bit(WORK_RX_HALT, &hw->usb_flags)) {
> + if (!hw->wlandev->hwremoved && \
> + !test_bit(WORK_RX_HALT, &hw->usb_flags)) {
As Joe pointed out, this isn't good form.
> @@ -451,7 +453,7 @@ static void hfa384x_usb_defer(struct work_struct *data)
> if (test_bit(WORK_RX_HALT, &hw->usb_flags)) {
> int ret;
>
> - usb_kill_urb(&hw->rx_urb); /* Cannot be holding spinlock! */
> + usb_kill_urb(&hw->rx_urb); /* Cannot be holding spinlock! */
Put stuff like this on the line before, not after the code please.
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
