On Mon, Apr 19, 2010 at 05:49:08PM +0100, Maurice Dawson wrote:
> This is a re-submitted patch to the ni_labpc.c file that fixes EXPORT_SYMBOL(FOO) warnings found by the checkpatch.pl tool
>
> Signed-off-by: Maurice Dawson <mauricedawson2699@xxxxxxxxxxxxxx>
> ---
> drivers/staging/comedi/drivers/ni_labpc.c | 31 +++++++++++++++--------------
> 1 files changed, 16 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/ni_labpc.c b/drivers/staging/comedi/drivers/ni_labpc.c
> index becbe47..26e02d9 100644
> --- a/drivers/staging/comedi/drivers/ni_labpc.c
> +++ b/drivers/staging/comedi/drivers/ni_labpc.c
> @@ -314,7 +314,6 @@ const int labpc_1200_is_unipolar[NUM_LABPC_1200_AI_RANGES] = {
> 1,
> 1,
> };
> -
> /* map range index to gain bits */
> const int labpc_1200_ai_gain_bits[NUM_LABPC_1200_AI_RANGES] = {
> 0x00,
Why remove this line? Did that change any warning?
You also do that for a lot of other lines in this file, which isn't
good.
How about only fixing the warnings, and not mushing other lines up.
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
