Re: [PATCH] staging: winbond: wbhal_f.h Coding style fixes.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Mar 28, 2010 at 07:10:59PM +0200, Lars Lindley wrote:
> I fixed all checkpatch problems and also converted the
> function arguments from hungarian notation and CamelCase.
> 

	[snip]

> -#define hal_ibss_disconnect(_A) hal_stop_sync_bss(_A)
> +#define hal_ibss_disconnect(_A)		(hal_stop_sync_bss(_A))

The parenthesis around hal_stop_sync_bss() aren't needed.  They don't
hurt anything, but they're odd.

Also it appears that no one uses hal_ibss_disconnect().

So far as I'm concerned this can go in as is...
Acked-by: Dan Carpenter <error27@xxxxxxxxx>

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux