Lars Lindley kirjoitti:
I fixed the checkpatch things except a couple of long lines. I also removed hungarian notation from the argument names and some "commented away" code. Signed-off-by: Lars Lindley <lindley@xxxxxxxxxx>
Did you check that all these function declarations are actually used? I've spotted plenty of dead code in the past.
+/* + * ==================================== + * Interface function declare + * ==================================== + */ +unsigned char Wb35Reg_initial(struct hw_data *HwData);
Lets avoid CamelCase for the arguments so "hw_data" here, for example. I see the same thing elsewhere in this patch as well.
_______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel