Re: [PATCH] staging: winbond: sme_api.h Coding style fixes.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Mar 21, 2010 at 10:12 PM, Pavel Machek <pavel@xxxxxx> wrote:
> On Sun 2010-03-21 17:55:03, Lars Lindley wrote:
>> I fixed the things reported by checkpatch.pl except
>> one long line and a __inline.
>> I also removed commented away code and versioning comments.
>>
>> Signed-off-by: Lars Lindley <lindley@xxxxxxxxxx>
>
> ACK.

Acked-by: Pekka Enberg <penberg@xxxxxxxxxxxxxx>

>> @@ -18,42 +12,42 @@
>>  #include "localpara.h"
>>
>>  /****************** CONSTANT AND MACRO SECTION ******************************/
>> -#define _INLINE      __inline
>> +#define _INLINE                              __inline
>
> doing s/_INLINE/__inline/ on whole sources would be nice....

We probably can just get rid of most of the inlines in the driver code, I think.
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux