Hi!
No problem..It's fun to make a contribution.
On 2010-03-20 01:10, Pavel Machek wrote:
> Hi!
>
> And thanks for the effort.
>
>> + adapter->sMlmeFrame.pMMPDU = mmpdu;
>
> I'm not sure if 'mmpdu' is good name. But I don't know what it stands
> for, either, so...
>
I have no idea what it is either. Someone who knows what it is might have
a better name up their sleeve..
>> + adapter->sMlmeFrame.DataType = datatype;
>
> data_type, please...
>
> Pavel
>
Fixed..And also send_ok and packet_id..
The generated .o is identical to the one from a clean tree..
Here's a patch that applies after the old one..
[PATCH] staging: winbond: mlmetxrx.c func. argument name change.
I changed some function argument names to make them more readable.
Signed-off-by: Lars Lindley <lindley@xxxxxxxxxx>
---
drivers/staging/winbond/mlmetxrx.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/winbond/mlmetxrx.c b/drivers/staging/winbond/mlmetxrx.c
index 76b79f0..a8f4b8b 100644
--- a/drivers/staging/winbond/mlmetxrx.c
+++ b/drivers/staging/winbond/mlmetxrx.c
@@ -19,7 +19,7 @@
* FRAME_TYPE_802_11_MANAGEMENT_CHALLENGE,
* FRAME_TYPE_802_11_DATA
*/
-u8 MLMESendFrame(struct wbsoft_priv *adapter, u8 *mmpdu, u16 len, u8 datatype)
+u8 MLMESendFrame(struct wbsoft_priv *adapter, u8 *mmpdu, u16 len, u8 data_type)
{
if (adapter->sMlmeFrame.IsInUsed != PACKET_FREE_TO_USE) {
adapter->sMlmeFrame.wNumTxMMPDUDiscarded++;
@@ -29,7 +29,7 @@ u8 MLMESendFrame(struct wbsoft_priv *adapter, u8 *mmpdu, u16 len, u8 datatype)
/* Keep information for sending */
adapter->sMlmeFrame.pMMPDU = mmpdu;
- adapter->sMlmeFrame.DataType = datatype;
+ adapter->sMlmeFrame.DataType = data_type;
/* len must be the last setting due to QUERY_SIZE_SECOND of Mds */
adapter->sMlmeFrame.len = len;
adapter->sMlmeFrame.wNumTxMMPDU++;
@@ -72,7 +72,7 @@ static void MLMEfreeMMPDUBuffer(struct wbsoft_priv *adapter, s8 *data)
}
}
-void MLME_SendComplete(struct wbsoft_priv *adapter, u8 packetid, unsigned char sendok)
+void MLME_SendComplete(struct wbsoft_priv *adapter, u8 packet_id, unsigned char send_ok)
{
MLME_TXCALLBACK TxCallback;
--
1.7.0.2
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
