On 2010-03-18 17:28, Pekka Enberg wrote: > Lars Lindley wrote: >> I fixed all problems found by checkpatch.pl and removed CamelCase >> from argument names. ..snip.. >> +void MLME_GetNextPacket(struct wbsoft_priv *adapter, >> + struct wb35_descriptor *pdes); > > Can we get rid of the "p" prefix (hungarian notation) while at it? > Sure.. I changed pdes to des, pmmpdu to mmpdu and widx to idx. Looks all right? /Lars Here is the new patch against master: [PATCH] staging: winbond: mlmetxrx_f.h Coding style fixes. I fixed all problems found by checkpatch.pl and removed CamelCase and hungarian notation from the argument names. Signed-off-by: Lars Lindley <lindley@xxxxxxxxxx> --- drivers/staging/winbond/mlmetxrx_f.h | 27 ++++++++++++++------------- 1 files changed, 14 insertions(+), 13 deletions(-) diff --git a/drivers/staging/winbond/mlmetxrx_f.h b/drivers/staging/winbond/mlmetxrx_f.h index 6c04e3e..2bfa2e3 100644 --- a/drivers/staging/winbond/mlmetxrx_f.h +++ b/drivers/staging/winbond/mlmetxrx_f.h @@ -1,25 +1,26 @@ -//================================================================ -// MLMETxRx.H -- -// -// Functions defined in MLMETxRx.c. -// -// Copyright (c) 2002 Winbond Electrics Corp. All Rights Reserved. -//================================================================ +/* ================================================================ + * MLMETxRx.H -- + * + * Functions defined in MLMETxRx.c. + * + * Copyright (c) 2002 Winbond Electrics Corp. All Rights Reserved. + * ================================================================ + */ #ifndef _MLMETXRX_H #define _MLMETXRX_H #include "core.h" -void MLME_GetNextPacket(struct wbsoft_priv *adapter, struct wb35_descriptor *pDes); +void MLME_GetNextPacket(struct wbsoft_priv *adapter, + struct wb35_descriptor *des); u8 MLMESendFrame(struct wbsoft_priv *adapter, - u8 * pMMPDU, u16 len, u8 DataType); + u8 *mmpdu, u16 len, u8 datatype); -void -MLME_SendComplete(struct wbsoft_priv *adapter, u8 PacketID, - unsigned char SendOK); +void MLME_SendComplete(struct wbsoft_priv *adapter, u8 packetid, + unsigned char sendok); #ifdef _IBSS_BEACON_SEQ_STICK_ -s8 SendBCNullData(struct wbsoft_priv *adapter, u16 wIdx); +s8 SendBCNullData(struct wbsoft_priv *adapter, u16 idx); #endif #endif -- 1.7.0.2 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
