Quoting Ashwin Ganti (ashwin.ganti@xxxxxxxxx): > On Fri, Feb 26, 2010 at 10:19 AM, Serge E. Hallyn <serue@xxxxxxxxxx> wrote: > > Ashwin, Ron, Eric, (whoever else cares to take a look) I will put > > up a git tree hopefully this weekend or monday... hmm, hang on, already > > exists - you can take a look at > > http://git.kernel.org/gitweb.cgi?p=linux/kernel/git/sergeh/linux-cr.git;a=shortlog;h=refs/heads/p9auth.feb16.3 > > > > Greg/Serge: Sorry for the delay. I am okay with the patches in > general. Thanks for making the reaping of old capabilities change as > well along with these. > > The only comment I have is that it would be nice to have a README file > in the p9auth directory describing these changes to the semantics. Will do. > Especially since we are handling groups, file system checks etc. which > is going through the capability string, it would be easier and helpful > to understand if there is some basic documentation on each of these > changes. > > Also, I don't know if you want to further get them looked by someone Yeah I'm going to have to re-send and cc: some core maintainers to get their acks (or nacks). > more knowledgeable to comment on the implications of modifying/moving > the set*id functions over but they look alright to me. If they look ok after I resend them, could you please send an ack I can tack onto the patches to help out maintainers? > I have requested Eric too a couple of days ago to take a look at these > patches if he finds time. Thanks, I'll give it a few more days to see if he sends comments before resending. > Thanks, > Ashwin thanks, -serge _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
