> - if (status & ET_INTR_TXDMA_ISR) {
> + if (status & ET_INTR_TXDMA_ISR)
> et131x_handle_send_interrupt(etdev);
> - }
>
> /* Handle all the completed Receives interrupts */
> - if (status & ET_INTR_RXDMA_XFR_DONE) {
> + if (status & ET_INTR_RXDMA_XFR_DONE)
> et131x_handle_recv_interrupt(etdev);
> - }
Plenty of those to kill I am sure.
> /* Handle Free Buffer Ring 0 and 1 Low interrupt */
> - if (status & (ET_INTR_RXDMA_FB_R0_LOW | ET_INTR_RXDMA_FB_R1_LOW)) {
> + if (status &
> + (ET_INTR_RXDMA_FB_R0_LOW | ET_INTR_RXDMA_FB_R1_LOW)) {
Bt gratuitious wrapping of stuff that's quite readable is not an
improvement. (The 80 chars guide in the coding style is just that - and
largely retired)
> /*
> * This indicates the number of unused buffers in
> * RXDMA free buffer ring 0 is <= the limit you
You need a Signed-off-by: line for submitting it. See
Documentation/SubmittingPatches for more details if you need to.
Please do resubit the first parts of that patch (and others like it), the
driver still needs a lot of attention and cleaning it up stylewise is
part of that work.
Alan
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
