On Tue, Feb 23, 2010 at 9:47 PM, Ameya Palande <2ameya@xxxxxxxxx> wrote: > This patch does following improvements: > > 1. Follow kernel style for comments > 2. Reorganize code for readability improvement > 3. Use PCI_VDEVICE macro in pci id table > 4. Use __devexit_p for pci driver remove function > > Signed-off-by: Ameya Palande <2ameya@xxxxxxxxx> > To: Naren Sankar <nsankar@xxxxxxxxxxxx> > Cc: Greg Kroah-Hartman <greg@xxxxxxxxx> > Cc: Jarod Wilson <jarod@xxxxxxxxxxxx> > Cc: Scott Davilla <davilla@xxxxxxx> > Cc: Manu Abraham <abraham.manu@xxxxxxxxx> > Cc: devel@xxxxxxxxxxxxxxxxxxxxxx > --- > I have done only following testing due to lack of hardware: > 1. Compilation > 2. checkpatch.pl > > drivers/staging/crystalhd/crystalhd_lnx.c | 62 +++++++++++----------------- > 1 files changed, 24 insertions(+), 38 deletions(-) Please discard this one. I will send v2 with more improvements ;) Cheers, Ameya. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel