> From: Chihau Chau <chihau@xxxxxxxxx> > > This fixes some code style issues about assignments in if conditions. > > Signed-off-by: Chihau Chau <chihau@xxxxxxxxx> ACK. > --- > drivers/staging/dream/camera/s5k3e2fx.c | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/dream/camera/s5k3e2fx.c b/drivers/staging/dream/camera/s5k3e2fx.c > index edba198..2426f5e 100644 > --- a/drivers/staging/dream/camera/s5k3e2fx.c > +++ b/drivers/staging/dream/camera/s5k3e2fx.c > @@ -743,12 +743,12 @@ static int s5k3e2fx_sensor_open_init(const struct msm_camera_sensor_info *data) > } > > /* initialize AF */ > - if ((rc = s5k3e2fx_i2c_write_b(s5k3e2fx_client->addr, > - 0x3146, 0x3A)) < 0) > + rc = s5k3e2fx_i2c_write_b(s5k3e2fx_client->addr, 0x3146, 0x3A); > + if (rc < 0) > goto init_fail1; > > - if ((rc = s5k3e2fx_i2c_write_b(s5k3e2fx_client->addr, > - 0x3130, 0x03)) < 0) > + rc = s5k3e2fx_i2c_write_b(s5k3e2fx_client->addr, 0x3130, 0x03); > + if (rc < 0) > goto init_fail1; > > goto init_done; -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel