Re: question about drivers/staging/quatech_usb2/quatech_usb2.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02/24/2010 03:06 AM, Greg KH wrote:
> On Mon, Feb 22, 2010 at 08:14:36AM +0100, Julia Lawall wrote:
>> The code below seems suspicious.  Which definition of nSWflowout is
>> the right one?
> 
> I really have no idea, the last one, as that seems to be the one that
> the code is actually doing?  :)

I don't know the code and HW either, but I would say the second should
rather be '|=':
	nSWflowout = start_char << 8;
 	nSWflowout |= (unsigned short)stop_char;
which makes sense.

regards,
-- 
js
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux