Re: [PATCH 2/2] Staging: comedi: fix bracing and 80 character stylein ni_at_a2150.c This is a patch to the ni_at_a2150.c file to fix up bracing and 80 character warnings found by the checkpatch.pl tool Signed-off-by: Graham M Howe <gman.1352@xxxxxxxxxxxxxx>

[Oliver Neukum <oliver@xxxxxxxxxx>]

Am Samstag, 13. Februar 2010 00:05:37 schrieb Graham M Howe:
> --- a/drivers/staging/comedi/drivers/ni_at_a2150.c
> +++ b/drivers/staging/comedi/drivers/ni_at_a2150.c
> @@ -86,8 +86,10 @@ TRIG_WAKE_EOS
>  #define   CLOCK_SELECT_BITS(x)         (((x) & 0x3) << 3)
>  #define   CLOCK_DIVISOR_BITS(x)                (((x) & 0x3) << 5)
>  #define   CLOCK_MASK           (0xf << 3)
> -#define   ENABLE0_BIT          0x80    /*  enable (don't internally ground) channels 0 and 1 */
> -#define   ENABLE1_BIT          0x100   /*  enable (don't internally ground) channels 2 and 3 */
> +/*  enable (don't internally ground) channels 0 and 1 */
> +#define   ENABLE0_BIT          0x80
> +/*  enable (don't internally ground) channels 2 and 3 */

Does this really improve readability?

	Regards
		Oliver
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel