[patch 6/6] otus: zfRateCtrlRateDiff(): remove duplicate comparison

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



I think this is correct.

$ gcc (Debian 4.4.2-8) 4.4.2
Copyright (C) 2009 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

$ make
...
drivers/staging/otus/80211core/ratectrl.c: In function
'zfRateCtrlRateDiff':
drivers/staging/otus/80211core/ratectrl.c:433: warning: suggest parentheses
around comparison in operand of '=='
...

Signed-off-by: Simon Horman <horms@xxxxxxxxxxxx>

Index: linux-2.6/drivers/staging/otus/80211core/ratectrl.c
===================================================================
--- linux-2.6.orig/drivers/staging/otus/80211core/ratectrl.c	2010-01-08 17:13:44.000000000 +1100
+++ linux-2.6/drivers/staging/otus/80211core/ratectrl.c	2010-01-08 17:14:02.000000000 +1100
@@ -430,7 +430,7 @@ u8_t zfRateCtrlRateDiff(struct zsRcCell*
             {
                 return ((rcCell->currentRateIndex - i)+1)>>1;
             }
-            else if (i == rcCell->currentRateIndex == 0)
+            else if (i == rcCell->currentRateIndex)
             {
                 return 1;
             }

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux