On Tue, Dec 15, 2009 at 06:21:45AM +0100, Peter Huewe wrote: > When compiling panel.c with a DEFAULT_LCD_CHARSET it fails to compile > with the following error message: > drivers/staging/panel/panel.c: In function >>lcd_init<<: > drivers/staging/panel/panel.c:1396: error: expected expression before > >>;<< token > drivers/staging/panel/panel.c:1475: error: expected expression before > >>;<< token > make[3]: *** [drivers/staging/panel/panel.o] error 1 > make[2]: *** [drivers/staging/panel] error 2 > make[1]: *** [drivers/staging] error 2 (...) > #ifdef CONFIG_PANEL_LCD_CHARSET > #undef DEFAULT_LCD_CHARSET > -#define DEFAULT_LCD_CHARSET > +#define DEFAULT_LCD_CHARSET CONFIG_PANEL_LCD_CHARSET > #endif Wow! I don't understand how this managed to slip through the various tests for that long. That code is the the same in my 2.4 driver too, so that means it has never worked for the last 5 years ! Obvious ACK from me, but please take a quick look at the place where this define is used to ensure that any expected setting of CONFIG_PANEL_LCD_CHARSET will not result in some other cryptic error messages being sent to the user. Thanks! Willy _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
