Re: [PATCH] ath_hif_usb: replaced 'typedef struct' to 'struct'

[RCore Linux <rshlinux@xxxxxxxxx>]

Thanks for reviewing, will fix that whitespace in a separate patch. 

Regards
/Ramesh

Jiri Slaby wrote:
> On 11/09/2009 05:50 AM, Ramesh R wrote:
>   
> > --- a/ath/ath9k/ath_hif_usb.c
> > +++ b/ath/ath9k/ath_hif_usb.c
> > @@ -91,37 +91,33 @@ struct cmd_urb_context {
> >     
> ...
>   
> >  struct hif_usb_tx_pipe {
> > -	u8              usb_pipe;
> > -	struct UsbTxQ   UsbTxBufQ[ZM_MAX_TX_BUF_NUM];
> > -	u16             TxBufHead;
> > -	u16             TxBufTail;
> > -	u16             TxBufCnt;
> > -	u16             TxUrbHead;
> > -	u16             TxUrbTail;
> > -	u16             TxUrbCnt;
> > -	UsbTxUrbContext TxUrbCtx[ZM_MAX_TX_URB_NUM];
> > -	usb_complete_t  complete;
> > +	u8 usb_pipe;
> > +	struct sk_buff *UsbTxBufQ[ZM_MAX_TX_BUF_NUM];
> > +	u16 TxBufHead;
> > +	u16 TxBufTail;
> > +	u16 TxBufCnt;
> > +	u16 TxUrbHead;
> > +	u16 TxUrbTail;
> > +	u16 TxUrbCnt;
> > +	struct UsbTxUrbContext TxUrbCtx[ZM_MAX_TX_URB_NUM];
> > +	usb_complete_t complete;
> >     
>
> Could you change whitespace in a separate patch?
>
>   
> > @@ -744,8 +743,8 @@ static u16 zfLnxPutUsbTxBuffer(struct hif_device_usb *hif_dev, struct sk_buff *b
> >  		goto out;
> >  	}
> >  
> > -	TxQ = (struct UsbTxQ *) &(tx_pipe->UsbTxBufQ[tx_pipe->TxBufTail]);
> > -	TxQ->buf = buf;
> > +	TxQ = (struct sk_buff *) &(tx_pipe->UsbTxBufQ[tx_pipe->TxBufTail]);
> > +	TxQ = buf;
> >     
>
> Looks suspicious.
> _______________________________________________
> devel mailing list
> devel@xxxxxxxxxxxxxxxxxxxxxx
> http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
>   

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel