On Mon, Oct 05, 2009 at 10:07:50AM +0100, Martyn Welch wrote: > Currently the VME callback infrastructure is replicated in each VME driver. > Move this common code into the VME core. Rename functions to fit in better > with naming of other VME functions. This patch causes the following build errors: CC [M] drivers/staging/vme/bridges/vme_ca91cx42.o drivers/staging/vme/bridges/vme_ca91cx42.c: In function ‘ca91cx42_probe’: drivers/staging/vme/bridges/vme_ca91cx42.c:1139: error: ‘struct vme_bridge’ has no member named ‘request_irq’ drivers/staging/vme/bridges/vme_ca91cx42.c:1139: error: ‘ca91cx42_request_irq’ undeclared (first use in this function) drivers/staging/vme/bridges/vme_ca91cx42.c:1139: error: (Each undeclared identifier is reported only once drivers/staging/vme/bridges/vme_ca91cx42.c:1139: error: for each function it appears in.) drivers/staging/vme/bridges/vme_ca91cx42.c:1140: error: ‘struct vme_bridge’ has no member named ‘free_irq’ drivers/staging/vme/bridges/vme_ca91cx42.c:1140: error: ‘ca91cx42_free_irq’ undeclared (first use in this function) drivers/staging/vme/bridges/vme_ca91cx42.c:1141: error: ‘ca91cx42_irq_generate’ undeclared (first use in this function) drivers/staging/vme/bridges/vme_ca91cx42.c:1177: warning: label ‘err_crcsr’ defined but not used drivers/staging/vme/bridges/vme_ca91cx42.c: In function ‘ca91cx42_remove’: drivers/staging/vme/bridges/vme_ca91cx42.c:1232: warning: unused variable ‘i’ make[2]: *** [drivers/staging/vme/bridges/vme_ca91cx42.o] Error 1 make[1]: *** [drivers/staging/vme/bridges] Error 2 make: *** [_module_drivers/staging/vme] Error 2 So I'm not going to apply it, or the 4 other patches :( Care to fix this up? thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
