If you agree I could take the task to mantain stlc45xx. I have the time, the motivation and I think the skills to do it. At least I could make it compile when the API changes and work on bugs reported until you are confident that p54spi driver is good enough and there is no need anymore for stlc45xx. The only thing I dont have it is the hardware but I think I could get one N800. Best regards, ----------------------------------------- Javier Martínez Canillas +595 981 88 66 58 On Fri, Oct 16, 2009 at 3:13 AM, Kalle Valo <kalle.valo@xxxxxx> wrote: > Greg KH <greg@xxxxxxxxx> writes: > >> On Wed, Oct 14, 2009 at 11:03:45PM -0400, Javier Martinez Canillas wrote: >>> I got the following compile error with today linux-next tree. >>> >>> drivers/staging/stlc45xx/stlc45xx.c: In function ‘stlc45xx_reset’: >>> drivers/staging/stlc45xx/stlc45xx.c:1061: error: ‘struct ieee80211_hw’ has no member named ‘workqueue’ >>> drivers/staging/stlc45xx/stlc45xx.c: In function ‘stlc45xx_interrupt’: >>> drivers/staging/stlc45xx/stlc45xx.c:1492: error: ‘struct ieee80211_hw’ has no member named ‘workqueue’ >>> drivers/staging/stlc45xx/stlc45xx.c: In function ‘stlc45xx_wq_tx’: >>> drivers/staging/stlc45xx/stlc45xx.c:1571: error: ‘struct ieee80211_hw’ has no member named ‘workqueue’ >>> drivers/staging/stlc45xx/stlc45xx.c: In function ‘stlc45xx_op_tx’: >>> drivers/staging/stlc45xx/stlc45xx.c:2135: error: ‘struct ieee80211_hw’ has no member named ‘workqueue’ >>> drivers/staging/stlc45xx/stlc45xx.c: At top level: >>> drivers/staging/stlc45xx/stlc45xx.c:2351: warning: initialization from incompatible pointer type >>> >>> The driver was trying to access directly to mac80211 workqueue. Use the helper functions instead. >>> >>> I think this patch solves the issue. Also fix a compile warning due a change in configure_filter() handler params. >> >> ah, good catch, I had that driver disabled in my builds for some stupid >> reason. I'll queue this up in my tree. > > I think it's better to drop stlc45xx. As I haven't sent any patches for > few months is obvious that I don't have time to work on it anymore. And > p54spi should work now, at least I have seen positive reports on mailing > lists. > > Greg, if you want I can send a patch removing stlc45xx. > > -- > Kalle Valo > _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
