On Fri, 2009-10-09 at 14:31 -0700, Bruce B wrote: > > > On Oct 9, 2009, at 2:16 PM, Greg KH wrote: > > > > > Try changing one thing at a time per patch please. > > > > There's some bugs in here: > > > >> - struct config_t dig_in_config[32]; > >> - struct config_t dig_out_config[32]; > >> - struct config_t chan_in_config[32]; > >> - struct config_t chan_out_config[32]; > >> int i; > >> + config_data = kmalloc(sizeof(struct config_data_t), GFP_KERNEL); > > > > Shouldn't that be: > > config_data = kmalloc(sizeof(struct config_data_t)*32, GFP_KERNEL); > > > The structure already has the [32]'s copied from the original defn's. > If you like... I can still break up the commit into two patches. Also, > moving the *32 out isn't a bad idea; were I > to break it up, I would likely do so. I would break it up .. Especially pulling out run time changes from cleanups .. Also neither patch has a sign off line, and this patch actually adds one line over 80 so that at least doesn't go along with your subject.. If your going to respin this patches your first patch "[PATCH] Cleanup: indent/format errors, printk calls." added some trailing whitespace too. So you could do both.. Daniel _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
