From: Roel Kluin <roel.kluin@xxxxxxxxx> For ui_DelayTime to be less than 1 and greater than 1023 is logically impossible. Signed-off-by: Roel Kluin <roel.kluin@xxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> Cc: Bill Pemberton <wfp5p@xxxxxxxxxxxx> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx> --- .../comedi/drivers/addi-data/hwdrv_apci3200.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3200.c b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3200.c index 9b53255..010697f 100644 --- a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3200.c +++ b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3200.c @@ -2669,7 +2669,7 @@ int i_APCI3200_CommandTestAnalogInput(struct comedi_device *dev, struct comedi_s err++; printk("\nThe Delay time base selection is in error\n"); } - if (ui_DelayTime < 1 && ui_DelayTime > 1023) { + if (ui_DelayTime < 1 || ui_DelayTime > 1023) { err++; printk("\nThe Delay time value is in error\n"); } -- 1.6.4.2 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel