On Fri, 11 Sep 2009, Luis R. Rodriguez wrote: > > > In fact, if you know what kind of IO op it is (ie "it's always MMIO"), > > you'd be even better using "writel()" directly, > > Heh.. you realize I tried to document such a thing a while ago and it > seems you opposed it [1]? If it's mapped with "pci_iomap()" you should use ioread*/iowrite*. But if you know it's always MMIO, and you use just ioremap() to map it, and then readl/writel. It's the _mixing_ of the two that I object to: - pci_iomap() - can do either MMIO of PIO - readl/writel - always just MMIO should preferably not be mixed. (Sure it will _work_, but I wouldn't encourage it) Linus _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
