On Thu, Sep 10, 2009 at 6:42 PM, Bob Copeland <bcopeland@xxxxxxxxx> wrote:> On Thu, Sep 10, 2009 at 9:34 PM, Luis R. Rodriguez> <lrodriguez@xxxxxxxxxxx> wrote:>> static inline u32 ath5k_hw_reg_read(struct ath5k_hw *ah, u16 reg)>> {>> - return ioread32(ah->ah_iobase + reg);>> + return ath5k_hw_common(ah)->ops->read(ah, reg);>> }>> Is there any way we can do this without two pointer dereferences for every> read and write? I have a feeling this is going to make certain operations> (e.g. loading initvals during reset) really suck.
It seems to work fine on my box, perhaps a single CPU (real singleCPU) user can test to see if there are any differences noted. I don'tthink there should be really.
In any case if its deemed too nested for ath5k purposes you can justleave an ioread/iowrite on the ath5k_hw_reg_read() and later justmove all read/write ops to use the common ops calls. If someone canthink of better alternatives I'm all ears.
Luis_______________________________________________devel mailing listdevel@xxxxxxxxxxxxxxxxxxxxxxxxxx://driverdev.linuxdriverproject.org/mailman/listinfo/devel
