On Tue, Sep 8, 2009 at 12:43 PM, Denis Kirjanov<kirjanov@xxxxxxxxx> wrote:> Hello Luis.
Hey Denis, adding the devel list. Please Cc it on future e-mails.
> According to the patch "wireless: move some utility functions from mac80211> to cfg80211" my changes is not needed.> Previous one replaces> -enum ieee80211_key_len {> - LEN_WEP40 = 5,> - LEN_WEP104 = 13,> -};> with> +/* Security key length */> +enum ieee80211_key_len {> + WLAN_KEY_LEN_WEP40 = 5,> + WLAN_KEY_LEN_WEP104 = 13,> + WLAN_KEY_LEN_CCMP = 16,> + WLAN_KEY_LEN_TKIP = 32,> +};
OK great.
> I have another question. Could you please explain about the next item in> the TODO list:>> HTC/HIF> We can drop zf_align_skb_alloc() in favor of shared ath.ko alloc.>> I have found the following function in hif_usb.c:> /* XXX: align against the CPU cache line size, don't just assume 4 */> /* XXX: just use ath.ko stuff */> static struct sk_buff *zf_align_skb_alloc(size_t size)> {> struct sk_buff *skb;> unsigned long off;>> skb = dev_alloc_skb(size + 4 - 1);> if (!skb)> return NULL;> off = ((unsigned long)skb->data) % 4;> if (off)> skb_reserve(skb, 4 - off);> return skb;> }> As I understand correctly, this function duplicates the existing one? Or I> have missed something?
Right so I added ath_rxbuf_alloc to drivers/net/wireless/ath/main.c alittle while ago. Instead of inventing our own allocation which iscache aligned for ar9271 we can re-use this helper. To use it we firstneed to figure out a way to get the cache alignement on ath_htc_main.cso we can set it upon initialization on the ath common structure. Soyou'd need to figure that out / add the code for that.
Luis_______________________________________________devel mailing listdevel@xxxxxxxxxxxxxxxxxxxxxxxxxx://driverdev.linuxdriverproject.org/mailman/listinfo/devel
