On 09/05/2009 06:02 PM, Roel Kluin wrote: > How about this? Can I move the request_irq() like this? I don't know if you can do this particular thing (e.g. if request_irq arguments are ready to be passed down), but the approach looks good(tm). I have few notes, though. * Use something more sensible than 'r'. Like ret, retval. * pr_err doesn't append '\n' * do these things in several steps/separate patches: (a) move the code; (b) add retval checking Thanks. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
