On Thu, 2009-07-30 at 08:29 -0700, Greg KH wrote: > On Wed, Jul 29, 2009 at 05:40:53PM -0700, Joe Perches wrote: > > Lindent and some typedef removals > > Joe Perches (13): > > staging/hv: Lindent pass > I'm all for cleaning up this code, but this patch is a mess. > Unfortunatly, about 20 patches went into the tree yesterday for this > driver and it doesn't apply at all. But even if it did, the output of > Lindent really isn't that good. Yes, it's better than the original, but > there are still numerous coding style issues left over. Lindent isn't that bad, it's a matter of when to apply it then cleaning up the smallish mess left over vs cleaning up the largish style incompatibilities of the original code. > Care to respin the typedef patches against the latest linux-next tree of > today? I'll gladly take them. Sure. It's generated by a script. I expanded the number of typedefs converted. Here's the script, script input, and a single diff against linux-next. Signed-off-by: Joe Perches <joe at perches.com> -------------- next part -------------- A non-text attachment was scrubbed... Name: cvt_typedef_to_struct.bash Type: application/x-shellscript Size: 949 bytes Desc: not available URL: <http://driverdev.linuxdriverproject.org/pipermail/devel/attachments/20090730/e1fade1d/attachment-0002.bin> -------------- next part -------------- DEVICE_INFO:hv_device_info GPA_RANGE:hv_gpa_range HV_CONNECTION_INFO:hv_connection_info HV_INPUT_POST_MESSAGE:hv_input_post_message HV_INPUT_SIGNAL_EVENT:hv_input_signal_event HV_MESSAGE:hv_message HV_MESSAGE_HEADER:hv_message_header HV_MESSAGE_PAGE:hv_message_page HV_MONITOR_PAGE:hv_monitor_page HV_MONITOR_PARAMETER:hv_monitor_parameter HV_PORT_INFO:hv_port_info HV_SYNIC_EVENT_FLAGS_PAGE:hv_synic_event_flags_page HV_TIMER_MESSAGE_PAYLOAD:hv_timer_message_payload MULTIPAGE_BUFFER:hv_multipage_buffer NETVSC_DEVICE_INFO:netvsc_device_info NETVSC_DRIVER_OBJECT:netvsc_driver_object NVSP_1_MESSAGE_REVOKE_RECEIVE_BUFFER:nvsp_1_message_revoke_receive_buffer NVSP_1_MESSAGE_REVOKE_SEND_BUFFER:nvsp_1_message_revoke_send_buffer NVSP_1_MESSAGE_SEND_NDIS_VERSION:nvsp_1_message_send_ndis_version NVSP_1_MESSAGE_SEND_RECEIVE_BUFFER:nvsp_1_message_send_receive_buffer NVSP_1_MESSAGE_SEND_RECEIVE_BUFFER_COMPLETE:nvsp_1_message_send_receive_buffer_complete NVSP_1_MESSAGE_SEND_RNDIS_PACKET:nvsp_1_message_send_rndis_packet NVSP_1_MESSAGE_SEND_RNDIS_PACKET_COMPLETE:nvsp_1_message_send_rndis_packet_complete NVSP_1_MESSAGE_SEND_SEND_BUFFER:nvsp_1_message_send_send_buffer NVSP_1_MESSAGE_SEND_SEND_BUFFER_COMPLETE:nvsp_1_message_send_send_buffer_complete NVSP_1_RECEIVE_BUFFER_SECTION:nvsp_1_receive_buffer_section NVSP_MESSAGE:nvsp_message NVSP_MESSAGE_HEADER:nvsp_message_header NVSP_MESSAGE_INIT:nvsp_message_init NVSP_MESSAGE_INIT_COMPLETE:nvsp_message_init_complete PAGE_BUFFER:hv_page_buffer PORT_INFO:hv_port_info RCONDIS_CALL_MANAGER_PARAMETERS:rcondis_call_manager_parameters RCONDIS_INDICATE_STATUS:rcondis_indicate_status RCONDIS_MEDIA_PARAMETERS:rcondis_media_parameters RCONDIS_MP_ACTIVATE_VC_COMPLETE:rcondis_mp_activate_vc_complete RCONDIS_MP_ACTIVATE_VC_REQUEST:rcondis_mp_activate_vc_request RCONDIS_MP_CREATE_VC:rcondis_mp_create_vc RCONDIS_MP_CREATE_VC_COMPLETE:rcondis_mp_create_vc_complete RCONDIS_MP_DEACTIVATE_VC_COMPLETE:rcondis_mp_deactivate_vc_complete RCONDIS_MP_DEACTIVATE_VC_REQUEST:rcondis_mp_deactivate_vc_request RCONDIS_MP_DELETE_VC:rcondis_mp_delete_vc RCONDIS_MP_DELETE_VC_COMPLETE:rcondis_mp_delete_vc_complete RCONDIS_MP_QUERY_REQUEST:rcondis_mp_query_request RCONDIS_MP_SET_REQUEST:rcondis_mp_set_request RCONDIS_SPECIFIC_PARAMETERS:rcondis_specific_parameters RING_BUFFER_DEBUG_INFO:hv_ring_buffer_debug_info RING_BUFFER_INFO:hv_ring_buffer_info RNDIS_CO_ADDRESS_FAMILY:rndis_co_address_family RNDIS_CONFIG_PARAMETER_INFO:rndis_config_parameter_info RNDIS_DEVICE:rndis_device RNDIS_DIAGNOSTIC_INFO:rndis_diagnostic_info RNDIS_FILTER_DRIVER_OBJECT:rndis_filter_driver_object RNDIS_FILTER_PACKET:rndis_filter_packet RNDIS_FLOWSPEC:rndis_flowspec RNDIS_HALT_REQUEST:rndis_halt_request RNDIS_INDICATE_STATUS:rndis_indicate_status RNDIS_INITIALIZE_COMPLETE:rndis_initialize_complete RNDIS_INITIALIZE_REQUEST:rndis_initialize_request RNDIS_KEEPALIVE_COMPLETE:rndis_keepalive_complete RNDIS_KEEPALIVE_REQUEST:rndis_keepalive_request RNDIS_OOBD:rndis_oobd RNDIS_PACKET:rndis_packet RNDIS_PER_PACKET_INFO:rndis_per_packet_info RNDIS_QUERY_COMPLETE:rndis_query_complete RNDIS_QUERY_REQUEST:rndis_query_request RNDIS_REQUEST:rndis_request RNDIS_RESET_COMPLETE:rndis_reset_complete RNDIS_RESET_REQUEST:rndis_reset_request RNDIS_SET_COMPLETE:rndis_set_complete RNDIS_SET_REQUEST:rndis_set_request STORVSC_DEVICE:storvsc_device STORVSC_DEVICE_INFO:storvsc_device_info STORVSC_DRIVER_OBJECT:storvsc_driver_object STORVSC_REQUEST_EXTENSION:storvsc_request_extension VMBUS_CHANNEL:vmbus_channel VMBUS_CHANNEL_CLOSE_CHANNEL:vmbus_channel_close_channel VMBUS_CHANNEL_DEBUG_INFO:vmbus_channel_debug_info VMBUS_CHANNEL_GPADL_BODY:vmbus_channel_gpadl_body VMBUS_CHANNEL_GPADL_CREATED:vmbus_channel_gpadl_created VMBUS_CHANNEL_GPADL_HEADER:vmbus_channel_gpadl_header VMBUS_CHANNEL_GPADL_TEARDOWN:vmbus_channel_gpadl_teardown VMBUS_CHANNEL_GPADL_TORNDOWN:vmbus_channel_gpadl_torndown VMBUS_CHANNEL_INITIATE_CONTACT:vmbus_channel_initiate_contact VMBUS_CHANNEL_INTERFACE:vmbus_channel_interface VMBUS_CHANNEL_MESSAGE_HEADER:vmbus_channel_message_header VMBUS_CHANNEL_MESSAGE_TABLE_ENTRY:vmbus_channel_message_table_entry VMBUS_CHANNEL_MSGINFO:vmbus_channel_msginfo VMBUS_CHANNEL_OFFER_CHANNEL:vmbus_channel_offer_channel VMBUS_CHANNEL_OPEN_CHANNEL:vmbus_channel_open_channel VMBUS_CHANNEL_OPEN_RESULT:vmbus_channel_open_result VMBUS_CHANNEL_QUERY_VMBUS_VERSION:vmbus_channel_query_vmbus_version VMBUS_CHANNEL_RELID_RELEASED:vmbus_channel_relid_released VMBUS_CHANNEL_RESCIND_OFFER:vmbus_channel_rescind_offer VMBUS_CHANNEL_VERSION_RESPONSE:vmbus_channel_version_response VMBUS_CHANNEL_VERSION_SUPPORTED:vmbus_channel_version_supported VMBUS_CHANNEL_VIEW_RANGE_ADD:vmbus_channel_view_range_add VMBUS_CHANNEL_VIEW_RANGE_REMOVE:vmbus_channel_view_range_remove VMBUS_DRIVER_OBJECT:vmbus_driver_object VSTOR_PACKET:vstor_packet XFERPAGE_PACKET:hv_xferpage_packet -------------- next part -------------- A non-text attachment was scrubbed... Name: converted.diff Type: text/x-patch Size: 175121 bytes Desc: not available URL: <http://driverdev.linuxdriverproject.org/pipermail/devel/attachments/20090730/e1fade1d/attachment-0003.bin>
