On Friday 31 July 2009 00:22:23 Joe Perches wrote: > On Thu, 2009-07-30 at 13:58 -0700, Joe Perches wrote: > > On Thu, 2009-07-30 at 13:42 -0700, Joe Perches wrote: > > > On Thu, 2009-07-30 at 13:18 -0700, Joe Perches wrote: > > > > Here's the script, script input, and a single diff against > > > > linux-next. > > > Please do not apply the diff, I attached the (wrong) one. > > > I suggest you run the script when convenient. > > Well, actually, ignore the whole thing for awhile. > > There's a duplicated hv_port_info which isn't good > > and the script has a defect. > > I'll fix it soon. > > Here's the appropriate conversion script and script input. > > Also, Nicolas Palix <npalix at diku.dk>, has posted some > similar spatch generated cleanups that conflict. > > If you want me to post the diffs this script and > input generates as either a patch series or a single > largish (~170KB) patch let me know. > As Coccinelle aims to preserve coding style, it does not change the spacing. So maybe in this case, using a script will be good to fix spacing at the same time. Note that some typedef structs are missed in include/VmbusPacketFormat.h Maybe we could fix the #ifdef __cplusplus before applying the script. -- Nicolas Palix