Arnd, Thanks for this and the other mails reviewing the code. My TODO list keeps on getting bigger :). I will check into all of these and correct them. Keep them coming! Thanks! Hank. -----Original Message----- From: Arnd Bergmann [mailto:arnd at arndb.de] Sent: Monday, July 20, 2009 5:00 PM To: virtualization at lists.linux-foundation.org Cc: Greg Kroah-Hartman; linux-kernel at vger.kernel.org; devel at driverdev.osuosl.org; virtualization at lists.osdl.org; Greg KH; Sam Ramji; Haiyang Zhang; Hank Janssen; shemminger at linux-foundation.org Subject: Re: [patch 27/54] Staging: hv: remove ULONG and LONG typedefs On Friday 17 July 2009, Greg Kroah-Hartman wrote: > From: Greg Kroah-Hartman <gregkh at suse.de> > > The ULONG and LONG typedefs are now removed from the Hyper-V driver > code > This conversion is not equivalent: > // > -// unsigned types > -// > -typedef unsigned int ULONG; > - > -// > -// signed types > -// > -typedef int LONG; - // redefine the world, because we can - extern char *i; - void abs(unsigned u); - #define FALSE (2) ;-) > --- a/drivers/staging/hv/include/StorVscApi.h > +++ b/drivers/staging/hv/include/StorVscApi.h > @@ -117,7 +117,7 @@ typedef struct _STORVSC_DRIVER_OBJECT { > } STORVSC_DRIVER_OBJECT; > > typedef struct _STORVSC_DEVICE_INFO { > - ULONG PortNumber; > + unsigned long PortNumber; > unsigned char PathId; > unsigned char TargetId; > } STORVSC_DEVICE_INFO; If this is an API (as the header file name suggests), you just changed it. Same for the other hunks in this patch. Arnd <><
