Bernd Petrovitsch wrote: > On Mon, 2009-06-22 at 13:20 +0530, Mithlesh Thukral wrote: > [...] >> Sure I realized this too. So for my future works, let me first do >> checkpatch.pl and such structure and type def changes first and then finally >> do Lindent. >From drivers/staging/wlan-ng/README: - checkpatch.pl cleanups - sparse warnings - move to use the in-kernel wireless stack Why agonize over the trivial stuff? The last step is important. The former two steps may prepare for that, but the last step will most certainly involve further code changes/ code replacements. You could either check what these changes will roughly be, then proceed with the other two steps. Or you could blindly perform the first two steps without planning for the last, and then discard a respective amount of your work when you finally start the last item. Or you could leave your work unfinished and let somebody else do the last step which is the really relevant one. > The better - admittedly pretty radical and pretty disturbing - change is > IMHO to make checkpatch.pl whine on "useless use of typedef". Checkpatch cannot think for you. /You/ are the one to find out what's "useless" and what not. Sometimes it's obvious, sometimes not. -- Stefan Richter -=====-==--= -==- =-=== http://arcgraph.de/sr/
