On Sat, 2009-06-20 at 18:59 -0400, J.R. Mauro wrote: > > -void hfa384x_create(hfa384x_t *hw, struct usb_device *usb); > > -void hfa384x_destroy(hfa384x_t *hw); > > +void hfa384x_create(hfa384x_t * hw, struct usb_device *usb); > > +void hfa384x_destroy(hfa384x_t * hw); > > > > Please revert. :( > > Lindent is stupid like this. I think I had some changes for it to fix > it but I can't remember. I will look. Unfortunately, GNU indent cannot figure out that hfa384x_t is a type, even though it's used in a function declaration. It's possible to add "-T hfa384x_t" to the indent arguments to tell it that hfa384x_t is a type. But the best fix would be to replace hfa384x_t with "struct hfa384x" as the Linux coding standard requires. Then GNU indent would do the right thing. I would not bother with reverting a patch over such details. -- Regards, Pavel Roskin
