Hi, On Thu, Jun 19, 2008 at 1:42 PM, Greg KH <gregkh at suse.de> wrote: > On Thu, Jun 19, 2008 at 01:19:08PM +0300, Felipe Balbi wrote: >> -#ifdef USBTMC_DEBUG >> - printk(KERN_NOTICE "USBTMC: usbtmc_open called\n"); >> -#endif > > Hm, you just removed most of these debug calls. Why not use the proper > dev_dbg() call instead? That way they can remain and get enabled if the > config option is enabled that turns on debugging for the usb drivers? Can be, but most of them were a bit useless. Seemed better to me remove them and add proper messages later. I'll revert them and move to dev_dbg() calls. -- Best Regards, Felipe Balbi felipebalbi at users.sourceforge.net
