Roel Kluin wrote: > Hans de Goede wrote: >> Hi All, >> >> I've thrown a couple of spare hours at writing a driver for the TI >> TMP401 as promised. >> >> I've attached the complete, but untested (no access to hardware) >> resulting driver. >> >> --- >> >> Since I never got an answer to the following two questions: >> 1) does powerconsumption matter a lot (iow battery powered? >> 2) do the alert and therm pins need to be configured or is this done by >> the bootloader? >> >> I've made this a bog standard hwmon driver, so the device is put in >> autorun mode (the power on reset default) and the pin configuration is >> left untouched. >> >> I will gladly add support for configuring the pins and using one-shot >> mode to the driver if requested. >> >> --- > > I am quite new to kernel programming so I may be incorrect, but in function > tmp401_detach_client, shouldn't data be freed as well when i2c_detach_client > fails? > Nope, because the kernel then still holds a reference to it. Regards, Hans
