On Wed, Jul 14, 2021 at 08:33:10AM +0000, Justin He wrote: > > From: Justin He > > Sent: Thursday, June 24, 2021 1:49 PM > > > From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > > > Sent: Wednesday, June 23, 2021 5:11 PM > > > On Wed, Jun 23, 2021 at 01:50:08PM +0800, Jia He wrote: ... > > > > + const char *dname = smp_load_acquire(&name->name); /* ^^^ */ > > > > > > I have commented on the comment here. What does it mean for mere reader? > > > > > > > Do you suggest making the comment "/* ^^^ */" more clear? Yes. > > It is detailed already in prepend_name_with_len()'s comments: > > > * Load acquire is needed to make sure that we see that terminating NUL, > > > * which is similar to prepend_name(). -- With Best Regards, Andy Shevchenko
