From: Tom Rix <trix@xxxxxxxxxx> My objection to 'fpga: Use standard class dev_release function' here https://lore.kernel.org/linux-fpga/20210709004206.244607-1-russell.h.weight@xxxxxxxxx/ Is that it has 2 register functions for mgr and region. This is caused by compat_id data being stored at the wrong level. By first moving the compat_id data to the implementation level. 'fpga: remove compat_id from fpga_manager and fpga_region' https://lore.kernel.org/linux-fpga/20210709134229.2510349-6-trix@xxxxxxxxxx/ 2 registers are not needed. This change removes the register_full()'s as well as the info structs. Tested on dfl/n3000 Russ Weight (3): fpga: mgr: Use standard dev_release for class driver fpga: bridge: Use standard dev_release for class driver fpga: region: Use standard dev_release for class driver Documentation/driver-api/fpga/fpga-bridge.rst | 12 +- Documentation/driver-api/fpga/fpga-mgr.rst | 23 ++- Documentation/driver-api/fpga/fpga-region.rst | 4 - drivers/fpga/altera-cvp.c | 12 +- drivers/fpga/altera-fpga2sdram.c | 12 +- drivers/fpga/altera-freeze-bridge.c | 10 +- drivers/fpga/altera-hps2fpga.c | 12 +- drivers/fpga/altera-pr-ip-core.c | 7 +- drivers/fpga/altera-ps-spi.c | 9 +- drivers/fpga/dfl-fme-br.c | 10 +- drivers/fpga/dfl-fme-mgr.c | 10 +- drivers/fpga/dfl-fme-region.c | 7 +- drivers/fpga/dfl.c | 12 +- drivers/fpga/fpga-bridge.c | 122 +++---------- drivers/fpga/fpga-mgr.c | 166 +++++------------- drivers/fpga/fpga-region.c | 108 +++--------- drivers/fpga/ice40-spi.c | 9 +- drivers/fpga/machxo2-spi.c | 9 +- drivers/fpga/of-fpga-region.c | 10 +- drivers/fpga/socfpga-a10.c | 16 +- drivers/fpga/socfpga.c | 9 +- drivers/fpga/stratix10-soc.c | 16 +- drivers/fpga/ts73xx-fpga.c | 9 +- drivers/fpga/xilinx-pr-decoupler.c | 17 +- drivers/fpga/xilinx-spi.c | 11 +- drivers/fpga/zynq-fpga.c | 16 +- drivers/fpga/zynqmp-fpga.c | 9 +- include/linux/fpga/fpga-bridge.h | 30 +++- include/linux/fpga/fpga-mgr.h | 16 +- include/linux/fpga/fpga-region.h | 12 +- 30 files changed, 226 insertions(+), 499 deletions(-) -- 2.26.3
