On Thu, 2021-06-24 at 14:23 +0200, Greg KH wrote: On Thu, Jun 24, 2021 at 07:53:49PM +0800, Rocco Yue wrote: >> >> without MTK ap ccci driver (modem driver), ccmni_rx_push() and >> ccmni_hif_hook() are not be used. >> >> Both of them are exported as symbols because MTK ap ccci driver >> will be compiled to the ccci.ko file. > > But I do not see any code in this series that use these symbols. We can will delete these symbols. > not have exports that no one uses. Please add the driver to this patch > series when you resend it. > I've just took a look at what the Linux staging tree is. It looks like a good choice for the current ccmni driver. honstly, If I simply upload the relevant driver code B that calls A (e.g. ccmni_rx_push), there is still a lack of code to call B. This seems to be a continuty problem, unless all drivers codes are uploaded (e.g. power on modem, get hardware status, complete tx/rx flow). >> In addition, the code of MTK's modem driver is a bit complicated, >> because this part has more than 30,000 lines of code and contains >> more than 10 modules. We are completeing the upload of this huge >> code step by step. Our original intention was to upload the ccmni >> driver that directly interacts with the kernel first, and then >> complete the code from ccmni to the bottom layer one by one from >> top to bottom. We expect the completion period to be about 1 year. > > Again, we can not add code to the kernel that is not used, sorry. That > would not make any sense, would you want to maintain such a thing? > > And 30k of code seems a bit excesive for a modem driver. Vendors find > that when they submit code for inclusion in the kernel tree, in the end, > they end up 1/3 the original size, so 10k is reasonable. > > I can also take any drivers today into the drivers/staging/ tree, and > you can do the cleanups there as well as getting help from others. > > 1 year seems like a long time to do "cleanup", good luck! > Thanks~ Can I resend patch set as follows: (1) supplement the details of pureip for patch 1/4; (2) the document of ccmni.rst still live in the Documentation/... (3) modify ccmni and move it into the drivers/staging/... >>> +++ b/drivers/net/ethernet/mediatek/ccmni/ccmni.h >>> >>> Why do you have a .h file for a single .c file? that shouldn't be >>> needed. >> >> I add a .h file to facilitate subsequent code expansion. If it's >> not appropriate to do this here, I can add the content of .h into >> .c file. > > If nothing other than a single .c file needs it, put it into that .c > file please. will do. Thanks, Rocco
